Skip to content

GitHub: Change formatting workflow messages #15116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 4, 2024
Merged

GitHub: Change formatting workflow messages #15116

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5dacc2
GitHub: Migrate to trusted-signing
yaira2 Apr 4, 2024
013fbf2
add perms to token
heftymouse Apr 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions .github/workflows/format-xaml.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ jobs:
defaults:
run:
shell: pwsh
permissions:
contents: write

steps:
- name: Generate GitHub Apps token
Expand All @@ -35,7 +37,7 @@ jobs:
run: |
if (!(gh pr -R ${{ github.repository }} view ${{ github.event.issue.number }} --json maintainerCanModify -q '.maintainerCanModify' | ConvertFrom-Json))
{
gh pr comment ${{ github.event.issue.number }} -b "This PR cannot be committed to. Ensure that Allow edits from maintainers is enabled."
gh pr comment ${{ github.event.issue.number }} -b "🔒 This PR cannot be committed to. Ensure that Allow edits from maintainers is enabled."
"CAN_RUN=0" | Out-File -FilePath $env:GITHUB_ENV -Append
}

Expand Down Expand Up @@ -68,7 +70,7 @@ jobs:
$changedFiles = (git diff --name-only pr..$baseRef) -split "\n" | Where-Object {$_ -like "*.xaml"}
if ($changedFiles.Count -eq 0)
{
gh pr comment ${{ github.event.issue.number }} -b "No XAML files found to format."
gh pr comment ${{ github.event.issue.number }} -b "⛔ No XAML files found to format."
"CAN_RUN=0" | Out-File -FilePath $env:GITHUB_ENV -Append
}

Expand All @@ -87,7 +89,7 @@ jobs:
git status --porcelain
if ((git status --porcelain) -eq $null)
{
gh pr comment ${{ github.event.issue.number }} -b "No XAML files changed."
gh pr comment ${{ github.event.issue.number }} -b "⛔ No XAML files changed."
"CAN_RUN=0" | Out-File -FilePath $env:GITHUB_ENV -Append
}
else
Expand Down Expand Up @@ -125,7 +127,7 @@ jobs:

if ($LASTEXITCODE -eq 0)
{
gh pr comment ${{ github.event.issue.number }} -b "Successfully formatted XAML files."
gh pr comment ${{ github.event.issue.number }} -b "✅ Successfully formatted XAML files."
}
else
{
Expand All @@ -134,5 +136,5 @@ jobs:
continue-on-error: true

- name: Comment if failed
if: failure() && env.CAN_RUN == 1
run: gh pr comment ${{ github.event.issue.number }} -b "Failed to format XAML files, check logs for more information."
if: failure() && env.CAN_RUN == 0
run: gh pr comment ${{ github.event.issue.number }} -b "⚠️ Failed to format XAML files, check [the logs](https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}) for more information."