Skip to content

Conversation

@hishitetsu
Copy link
Member

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Feature: Filter current directory when typing into search box #14391

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?

@yaira2 yaira2 added the ready for review Pull requests that are ready for review label Apr 5, 2024
@yaira2
Copy link
Member

yaira2 commented Apr 5, 2024

This is working well 🎉

Would it make sense to support filtering results in the search page as well?

@yaira2
Copy link
Member

yaira2 commented Apr 5, 2024

There are some weird behaviors in the columns view but I don't think it's a blocking issue.

@hishitetsu
Copy link
Member Author

Would it make sense to support filtering results in the search page as well?

I think it makes sense, because filtering will get you to the desired file faster than re-searching.

There are some weird behaviors in the columns view but I don't think it's a blocking issue.

Same opinion. It may also be a good idea to disable filtering in the column layout.

@hishitetsu hishitetsu marked this pull request as draft April 5, 2024 17:24
@hishitetsu
Copy link
Member Author

I found that sorting after filtering will remove the filtering. I'll fix it.

@hishitetsu hishitetsu removed the ready for review Pull requests that are ready for review label Apr 5, 2024
@hishitetsu hishitetsu marked this pull request as ready for review April 6, 2024 08:08
@hishitetsu
Copy link
Member Author

I found that sorting after filtering will remove the filtering. I'll fix it.

Fixed.

@hishitetsu hishitetsu added the ready for review Pull requests that are ready for review label Apr 6, 2024
Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good codewise.

@yaira2
Copy link
Member

yaira2 commented Apr 7, 2024

@hishitetsu what about grouping?

@hishitetsu
Copy link
Member Author

@hishitetsu what about grouping?

There should be no problem.

@yaira2 yaira2 merged commit 5fcd216 into files-community:main Apr 7, 2024
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Apr 7, 2024
@yaira2
Copy link
Member

yaira2 commented Apr 7, 2024

Nice work!

@hishitetsu hishitetsu deleted the FilterFileList branch April 7, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Filter current directory when typing into search box

3 participants