-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Feature: Added support for filtering current directory when typing into search box #15119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This is working well 🎉 Would it make sense to support filtering results in the search page as well? |
|
There are some weird behaviors in the columns view but I don't think it's a blocking issue. |
I think it makes sense, because filtering will get you to the desired file faster than re-searching.
Same opinion. It may also be a good idea to disable filtering in the column layout. |
|
I found that sorting after filtering will remove the filtering. I'll fix it. |
Fixed. |
0x5bfa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good codewise.
|
@hishitetsu what about grouping? |
There should be no problem. |
|
Nice work! |
Resolved / Related Issues
Closes Feature: Filter current directory when typing into search box #14391
Validation
How did you test these changes?