Feature: Updated the Toolbar design #15442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaira2
commented
May 21, 2024
Comment on lines
-183
to
-184
| <Setter Target="Content.CornerRadius" Value="0" /> | ||
| <Setter Target="Content.BorderThickness" Value="0,1,0,1" /> |
Member
Author
There was a problem hiding this comment.
Content is floating now so we don't need to modify via the visual state
yaira2
commented
May 21, 2024
| <Setter Target="Content.BorderThickness" Value="0,1,0,1" /> | ||
| <Setter Target="SidebarResizer.Visibility" Value="Collapsed" /> | ||
| <Setter Target="ContentPresenter.Margin" Value="0,0,0,0" /> | ||
| <Setter Target="ContentPresenter.Margin" Value="8,0,8,0" /> |
Member
Author
There was a problem hiding this comment.
The regular margin is 2,0,8,0 but in the narrow view the sidebar is hidden and thus, we change to 8,0,8,0.
yaira2
commented
May 21, 2024
| <Border | ||
| x:Name="ContentHeaderPresenter" | ||
| Grid.Row="0" | ||
| Margin="0,0,0,4" |
Member
Author
There was a problem hiding this comment.
This margin provides space between the header and content. I'm not so happy about this and I'm open to other ideas.
yaira2
commented
May 21, 2024
yaira2
commented
May 21, 2024
| } | ||
| } | ||
| else | ||
| appearance.AppThemeAddressBarBackgroundColor = ""; //migrate to new default |
Member
Author
There was a problem hiding this comment.
It's been a while since we've migrated to the new default so I think this can be removed.
yaira2
commented
May 21, 2024
| </UserControl.Resources> | ||
|
|
||
| <Grid Padding="8,0"> | ||
| <Grid Padding="8,0,0,0"> |
Member
Author
There was a problem hiding this comment.
Removed the right spacing to match the content area
yaira2
commented
May 21, 2024
| Grid.Column="2" | ||
| MinWidth="4" | ||
| Margin="0,8,0,40" | ||
| Margin="0,60,0,40" |
Member
Author
There was a problem hiding this comment.
Increased margin to reflect the floating toolbar
0x5bfa
reviewed
May 22, 2024
yaira2
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
To prevent extra work, all changes to the Files codebase must link to an approved issue marked as
Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.Steps used to test these changes
Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.