-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Feature: Updated the Toolbar design #15442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -99,7 +99,7 @@ | |
| Grid.RowSpan="2" | ||
| Grid.Column="2" | ||
| MinWidth="4" | ||
| Margin="0,8,0,40" | ||
| Margin="0,60,0,40" | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Increased margin to reflect the floating toolbar |
||
| HorizontalAlignment="Left" | ||
| AllowFocusOnInteraction="True" | ||
| Background="Transparent" | ||
|
|
@@ -128,24 +128,39 @@ | |
| x:Name="ContentPresenter" | ||
| Grid.Row="1" | ||
| Grid.Column="2" | ||
| Margin="2,0,0,0" | ||
| Margin="2,0,8,0" | ||
| HorizontalAlignment="Stretch"> | ||
| <Grid.RowDefinitions> | ||
| <RowDefinition Height="Auto" /> | ||
| <RowDefinition Height="*" /> | ||
| <RowDefinition Height="Auto" /> | ||
| </Grid.RowDefinitions> | ||
|
|
||
| <!-- Header --> | ||
| <Border | ||
| x:Name="ContentHeaderPresenter" | ||
| Grid.Row="0" | ||
| Margin="0,0,0,4" | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This margin provides space between the header and content. I'm not so happy about this and I'm open to other ideas. |
||
| VerticalAlignment="Stretch" | ||
| Background="{ThemeResource App.Theme.Toolbar.BackgroundBrush}" | ||
| BackgroundSizing="InnerBorderEdge" | ||
| BorderBrush="{ThemeResource CardStrokeColorDefaultBrush}" | ||
| BorderThickness="1" | ||
| Child="{x:Bind ContentHeader, Mode=OneWay}" | ||
| CornerRadius="8" | ||
| TabFocusNavigation="Local" /> | ||
|
|
||
| <!-- Content --> | ||
| <Border | ||
| x:Name="Content" | ||
| Grid.Row="0" | ||
| Grid.Row="1" | ||
| VerticalAlignment="Stretch" | ||
| Background="{ThemeResource App.Theme.FileArea.BackgroundBrush}" | ||
| BackgroundSizing="InnerBorderEdge" | ||
| BorderBrush="{ThemeResource DividerStrokeColorDefaultBrush}" | ||
| BorderThickness="1,1,0,1" | ||
| BorderThickness="1" | ||
| Child="{x:Bind InnerContent, Mode=OneWay}" | ||
| CornerRadius="8,0,0,8" | ||
| CornerRadius="8" | ||
| TabFocusNavigation="Local" | ||
| Translation="0,0,8"> | ||
| <Border.Shadow> | ||
|
|
@@ -156,7 +171,7 @@ | |
| <!-- Footer --> | ||
| <Border | ||
| x:Name="ContentFooterPresenter" | ||
| Grid.Row="1" | ||
| Grid.Row="2" | ||
| VerticalAlignment="Stretch" | ||
| Child="{x:Bind ContentFooter, Mode=OneWay}" | ||
| TabFocusNavigation="Local" /> | ||
|
|
@@ -180,10 +195,8 @@ | |
| <Setter Target="PaneColumnGrid.CornerRadius" Value="0,8,0,8" /> | ||
| <Setter Target="ContentPresenter.(Grid.Column)" Value="0" /> | ||
| <Setter Target="ContentPresenter.(Grid.ColumnSpan)" Value="3" /> | ||
| <Setter Target="Content.CornerRadius" Value="0" /> | ||
| <Setter Target="Content.BorderThickness" Value="0,1,0,1" /> | ||
|
Comment on lines
-183
to
-184
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Content is floating now so we don't need to modify via the visual state |
||
| <Setter Target="SidebarResizer.Visibility" Value="Collapsed" /> | ||
| <Setter Target="ContentPresenter.Margin" Value="0,0,0,0" /> | ||
| <Setter Target="ContentPresenter.Margin" Value="8,0,8,0" /> | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The regular margin is |
||
| <!-- Specific to collapsed pane --> | ||
| <Setter Target="PaneColumnGridTransform.TranslateX" Value="{StaticResource SidebarNegativeOpenPaneLength}" /> | ||
| <Setter Target="PaneColumnGrid.Visibility" Value="Collapsed" /> | ||
|
|
@@ -199,10 +212,8 @@ | |
| <Setter Target="PaneColumnGrid.CornerRadius" Value="0,8,0,8" /> | ||
| <Setter Target="ContentPresenter.(Grid.Column)" Value="0" /> | ||
| <Setter Target="ContentPresenter.(Grid.ColumnSpan)" Value="3" /> | ||
| <Setter Target="Content.CornerRadius" Value="0" /> | ||
| <Setter Target="Content.BorderThickness" Value="0,1,0,1" /> | ||
| <Setter Target="SidebarResizer.Visibility" Value="Collapsed" /> | ||
| <Setter Target="ContentPresenter.Margin" Value="0,0,0,0" /> | ||
| <Setter Target="ContentPresenter.Margin" Value="8,0,8,0" /> | ||
| <!-- Specific to expanded pane --> | ||
| <Setter Target="PaneLightDismissLayer.Visibility" Value="Visible" /> | ||
| <Setter Target="PaneColumnGrid.Shadow"> | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -101,7 +101,7 @@ | |
| </Style> | ||
| </UserControl.Resources> | ||
|
|
||
| <Grid Padding="8,0"> | ||
| <Grid Padding="8,0,0,0"> | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removed the right spacing to match the content area |
||
| <Grid.ColumnDefinitions> | ||
| <ColumnDefinition /> | ||
| <ColumnDefinition Width="Auto" /> | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's been a while since we've migrated to the new default so I think this can be removed.