Skip to content

Conversation

@d2dyno1
Copy link
Member

@d2dyno1 d2dyno1 commented May 22, 2024

Resolved / Related Issues

Steps used to test these changes

  1. Changed tabs using Ctrl + Shift + Tab
  2. Changed tabs using Ctrl + Tab
  3. Changed tabs using Ctrl + 1..9

@yaira2 yaira2 changed the title Fix file list being unfocused when changing tabs using keys Fix: Fixed an issue where the focus was lost when quickly switching tabs May 22, 2024
@yaira2 yaira2 self-requested a review May 22, 2024 20:37
@yaira2 yaira2 requested a review from Josh65-2201 May 22, 2024 20:40
@yaira2
Copy link
Member

yaira2 commented May 22, 2024

@Josh65-2201 can you confirm if this fixes the issue for you?

@yaira2 yaira2 added the ready for review Pull requests that are ready for review label May 22, 2024
@Josh65-2201
Copy link
Member

Josh65-2201 commented May 22, 2024

Works for Ctrl + Shift + Tab and Ctrl + 1-9 but doesn't for Ctrl + Tab

@yaira2
Copy link
Member

yaira2 commented May 31, 2024

@Josh65-2201 should we move forward with this as it's a partial fix?

@Josh65-2201
Copy link
Member

Yes

@yaira2
Copy link
Member

yaira2 commented Jun 2, 2024

@Josh65-2201 can you check with the latest commit?

Copy link
Member

@Josh65-2201 Josh65-2201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for all three

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Jun 2, 2024
@yaira2
Copy link
Member

yaira2 commented Jun 2, 2024

@d2dyno1 thank you!

@yaira2 yaira2 merged commit 892cadb into files-community:main Jun 2, 2024
@d2dyno1 d2dyno1 deleted the d2/fix_focus branch June 2, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Focus is lost when changing tabs

3 participants