Code Quality: Convert Multiple Localized Strings to ICU Message Format | Stage Three

[XTorLukas]

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

• From Code Quality: Change all multiple localized singular and plural strings to a single ICU message format string #15503

TODO list: #15503 (comment)

Stage three

☑️ PropertiesFilesAndFoldersCountString ----> PropertiesFilesAndFoldersCountString

Files/src/Files.App/Strings/en-US/Resources.resw

Lines 471 to 473 in af0ab75

	<data name="PropertiesFilesAndFoldersCountString" xml:space="preserve">
	<value>{0:#,##0} files, {1:#,##0} folders</value>
	</data>

☑️ PropertiesFilesFoldersAndLocationsCountString ----> PropertiesLocationsCountString

Files/src/Files.App/Strings/en-US/Resources.resw

Lines 474 to 476 in af0ab75

	<data name="PropertiesFilesFoldersAndLocationsCountString" xml:space="preserve">
	<value>{0:#,##0} files, {1:#,##0} folders from {2:#,##0} locations</value>
	</data>

[XTorLukas]

Test results

[0x5bfa]

Code wise good.

We have three extension methods:

• GetLocalizedResource
• GetLocalized
• GetLocalizedFormatResource

This is redundant, could they be merged?

[yaira2]

Code wise good.

We have three extension methods:

• GetLocalizedResource
• GetLocalized
• GetLocalizedFormatResource

This is redundant, could they be merged?

Please!

[XTorLukas]

Code wise good.

We have three extension methods:

• GetLocalizedResource
• GetLocalized
• GetLocalizedFormatResource

This is redundant, could they be merged?

Yes Yes although I already counted on it, and the GetLocalizedFormatResource method handles everything

[XTorLukas]

After rename to global one GetLocalized