-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Fix: Fixed an issue where dragging or opening multiple items would use the wrong sort mode #15885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, it's very good!
Co-authored-by: hishitetsu <66369541+hishitetsu@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code quality
Co-authored-by: 0x5BFA <62196528+0x5bfa@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, code wise.
As to 'internal' modifier, we can leave as is to keep consitency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@qin-shihuang thank you! I previously attempted to fix this but couldn't get the logic quite right, really appreciate your help on this! |
Resolved / Related Issues
Steps used to test these changes
These changes make the behavior of opening or dragging and dropping multiple files consistent with Files Explorer.