Skip to content

Conversation

@el-ev
Copy link
Contributor

@el-ev el-ev commented Jul 28, 2024

Resolved / Related Issues

Steps used to test these changes

These changes make the behavior of opening or dragging and dropping multiple files consistent with Files Explorer.

  1. Prepare 6 video files, named 1-6
  2. Select them in any order
  3. Click play all on tool bar or enter on keyboard
  4. The 6 files open in the player in the same order as they appear in the file list
  5. Set sorting to "by name ascending"
  6. Select the 6 files in any order
  7. Right-click on file 3, choose "Open" from the menu
  8. The 6 files open in the player in the order: 3 -> 4 -> 5 -> 6 -> 1 -> 2
  9. Select the 6 files in any order
  10. Drag file 3 and drop on a Windows Media Player window
  11. The 6 files open in the player in the order: 3 -> 4 -> 5 -> 6 -> 1 -> 2

@0x5bfa 0x5bfa added the ready for review Pull requests that are ready for review label Jul 28, 2024
@yaira2 yaira2 requested a review from hishitetsu July 28, 2024 14:43
@yaira2 yaira2 changed the title Fix: Fixed the wrong order of files when they are opened or dropped Fix: Fixed an issue where dragging or opening multiple items would use the wrong sort mode Jul 28, 2024
@0x5bfa 0x5bfa self-requested a review July 29, 2024 13:15
Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it's very good!

el-ev and others added 2 commits July 30, 2024 11:39
Co-authored-by: hishitetsu <66369541+hishitetsu@users.noreply.github.com>
Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code quality

el-ev and others added 2 commits July 30, 2024 13:36
Co-authored-by: 0x5BFA <62196528+0x5bfa@users.noreply.github.com>
@el-ev el-ev requested a review from 0x5bfa July 30, 2024 06:25
Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, code wise.
As to 'internal' modifier, we can leave as is to keep consitency

Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Jul 30, 2024
@yaira2 yaira2 merged commit 5795bb6 into files-community:main Jul 30, 2024
@yaira2
Copy link
Member

yaira2 commented Jul 30, 2024

@qin-shihuang thank you! I previously attempted to fix this but couldn't get the logic quite right, really appreciate your help on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Files doesn't open items by file name and uses selection order Bug: Files doesn't drag and drop in sequential order into mpv

4 participants