Skip to content

Conversation

@mdtauk
Copy link
Contributor

@mdtauk mdtauk commented Jul 29, 2024

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

  • Closes #

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Opened Files ...
  2. ...

@yaira2 yaira2 changed the title Added 12px Sized Nav Icons & Updated Actions.Sync icon Code Quality: Added 12px Sized Nav Icons & Updated Actions.Sync icon Jul 29, 2024
@yaira2
Copy link
Member

yaira2 commented Jul 29, 2024

Where are the smaller icons supposed to be used?

@mdtauk
Copy link
Contributor Author

mdtauk commented Jul 29, 2024

Where are the smaller icons supposed to be used?

If we do support reducing the button widths for the Address Bar / Navigation buttons, when the window is narrower, these 12px icons should be used, so the icons do not look too large.

@yaira2
Copy link
Member

yaira2 commented Jul 29, 2024

LGTM

@yaira2 yaira2 merged commit 6b3800f into files-community:main Jul 29, 2024
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Jul 29, 2024
@mdtauk mdtauk deleted the mdta-12pxNavIcons branch July 29, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants