Feature: Added an option to change the default IDE #16730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

yaira2 merged 24 commits into files-community:main from ferrariofilippo:feature_open_in_ide

Feb 26, 2025

Contributor

ferrariofilippo commented Jan 23, 2025

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Closes Feature: Add a setting to change the "open" ide on the status bar #12857

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

Open Settings>Dev Tools
Play with IDE settings
Open a git repo and use the Open in ... command

ferrariofilippo marked this pull request as draft

January 23, 2025 14:39

ferrariofilippo marked this pull request as ready for review

February 6, 2025 13:14

Lamparter reviewed

View reviewed changes

src/Files.App/Views/Settings/DevToolsPage.xaml Show resolved Hide resolved

yaira2 reviewed

View reviewed changes

src/Files.App/Actions/Open/OpenRepoInIDEAction.cs Outdated Show resolved Hide resolved

yaira2 force-pushed the feature_open_in_ide branch from 6934fa9 to 9735110 Compare

February 9, 2025 20:33

yaira2 reviewed

View reviewed changes

src/Files.App/Data/Contracts/IDevToolsSettingsService.cs Outdated Show resolved Hide resolved

yaira2 reviewed

View reviewed changes

src/Files.App/Services/Settings/DevToolsSettingsService.cs Outdated Show resolved Hide resolved

yaira2 reviewed

View reviewed changes

src/Files.App/ViewModels/Settings/DevToolsViewModel.cs Show resolved Hide resolved

yaira2 reviewed

View reviewed changes

src/Files.App/ViewModels/Settings/DevToolsViewModel.cs Outdated Show resolved Hide resolved

yaira2 reviewed

View reviewed changes

src/Files.App/Views/Settings/DevToolsPage.xaml Outdated Show resolved Hide resolved

yaira2 added the ready for review label

yaira2 reviewed

View reviewed changes

src/Files.App/Strings/en-US/Resources.resw Outdated Show resolved Hide resolved

yaira2 reviewed

View reviewed changes

src/Files.App/Strings/en-US/Resources.resw Outdated Show resolved Hide resolved

yaira2 reviewed

View reviewed changes

src/Files.App/Strings/en-US/Resources.resw Outdated Show resolved Hide resolved

yaira2 reviewed

View reviewed changes

src/Files.App/Strings/en-US/Resources.resw Outdated Show resolved Hide resolved

yaira2 reviewed

View reviewed changes

src/Files.App/Strings/en-US/Resources.resw Outdated Show resolved Hide resolved

yaira2 reviewed

View reviewed changes

src/Files.App/Strings/en-US/Resources.resw Outdated Show resolved Hide resolved

yaira2 changed the title ~~Feature: Add a setting to change the default IDE~~ Feature: Added an option to change the default IDE

yaira2 force-pushed the feature_open_in_ide branch from 1420b70 to ecf7572 Compare

February 16, 2025 16:36

ferrariofilippo and others added 11 commits

February 23, 2025 14:51


          Feature: Add a setting to change the default IDE

c19c984


          Added file picker

ae8c315


          UI Update

aabba54


          Added Test button

fb677f8


          Use default IDE

823ced5


          Run test with hidden PS

3b51583


          partial

d91ae8f


          Requested changes & Build Errors

f8a52ae


          Placeholder & Do not require testing

7a3a777


          Check environment variables

ea8af57


          Strings update

5e097d1

yaira2 and others added 6 commits

February 23, 2025 14:51


          Use ide friendly name

fe57c4f


          Responsive Layout

6f50a94


          Use teaching tip

7d1d949


          UI Changes

7b10006


          Suggested UI Changes

a3193ee


          Use light dismiss tooltips

ac56666

yaira2 force-pushed the feature_open_in_ide branch from 98f6892 to ac56666 Compare

February 23, 2025 19:51

ferrariofilippo force-pushed the feature_open_in_ide branch from 16c1ced to ac56666 Compare

February 23, 2025 21:22


          Change "Friendly name" to just "Name"

61c95db

yaira2 reviewed

View reviewed changes

src/Files.App/Views/Settings/DevToolsPage.xaml Outdated Show resolved Hide resolved

yaira2 reviewed

View reviewed changes

src/Files.App/Views/Settings/DevToolsPage.xaml Show resolved Hide resolved


          Use default styles

ca63881

yaira2 reviewed

View reviewed changes

src/Files.App/Views/Settings/DevToolsPage.xaml Outdated Show resolved Hide resolved


          Simplify header property

64ab57d

yaira2 reviewed

View reviewed changes

src/Files.App/Strings/en-US/Resources.resw Outdated Show resolved Hide resolved

yaira2 reviewed

View reviewed changes

src/Files.App/Views/Settings/DevToolsPage.xaml Outdated Show resolved Hide resolved

ferrariofilippo added 4 commits

February 25, 2025 23:20


          Use State triggers

1f86e2f


          Merge branch 'feature_open_in_ide' of https://github.com/ferrariofili…

02fc15f

…ppo/Files into feature_open_in_ide


          Browse button padding

339012c


          Revert padding and use fixed height

yaira2 approved these changes

View reviewed changes

Member

yaira2 left a comment

LGTM

yaira2 merged commit bc3572b into files-community:main

6 checks passed

yaira2 added ready to merge and removed ready for review labels

ferrariofilippo deleted the feature_open_in_ide branch

February 26, 2025 20:58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels