Skip to content

Code Quality: Update localization to use centralized Strings class 4 #16884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 2, 2025
Merged

Code Quality: Update localization to use centralized Strings class 4 #16884

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Files.App/Actions/Content/Archives/Compress/CompressIntoArchiveAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@ namespace Files.App.Actions
internal sealed partial class CompressIntoArchiveAction : BaseCompressArchiveAction
{
public override string Label
=> "CreateArchive".GetLocalizedResource();
=> Strings.CreateArchive.GetLocalizedResource();

public override string Description
=> "CompressIntoArchiveDescription".GetLocalizedResource();
=> Strings.CompressIntoArchiveDescription.GetLocalizedResource();

public CompressIntoArchiveAction()
{
Expand Down
4 changes: 2 additions & 2 deletions src/Files.App/Actions/Content/Archives/Compress/CompressIntoSevenZipAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@ namespace Files.App.Actions
internal sealed partial class CompressIntoSevenZipAction : BaseCompressArchiveAction
{
public override string Label
=> string.Format("CreateNamedArchive".GetLocalizedResource(), $"{StorageArchiveService.GenerateArchiveNameFromItems(context.SelectedItems)}.7z");
=> string.Format(Strings.CreateNamedArchive.GetLocalizedResource(), $"{StorageArchiveService.GenerateArchiveNameFromItems(context.SelectedItems)}.7z");

public override string Description
=> "CompressIntoSevenZipDescription".GetLocalizedResource();
=> Strings.CompressIntoSevenZipDescription.GetLocalizedResource();

public CompressIntoSevenZipAction()
{
Expand Down
4 changes: 2 additions & 2 deletions src/Files.App/Actions/Content/Archives/Compress/CompressIntoZipAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@ namespace Files.App.Actions
internal sealed partial class CompressIntoZipAction : BaseCompressArchiveAction
{
public override string Label
=> string.Format("CreateNamedArchive".GetLocalizedResource(), $"{StorageArchiveService.GenerateArchiveNameFromItems(context.SelectedItems)}.zip");
=> string.Format(Strings.CreateNamedArchive.GetLocalizedResource(), $"{StorageArchiveService.GenerateArchiveNameFromItems(context.SelectedItems)}.zip");

public override string Description
=> "CompressIntoZipDescription".GetLocalizedResource();
=> Strings.CompressIntoZipDescription.GetLocalizedResource();

public CompressIntoZipAction()
{
Expand Down
4 changes: 2 additions & 2 deletions src/Files.App/Actions/Content/Archives/Decompress/DecompressArchive.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@ namespace Files.App.Actions
internal sealed partial class DecompressArchive : BaseDecompressArchiveAction
{
public override string Label
=> "ExtractFiles".GetLocalizedResource();
=> Strings.ExtractFiles.GetLocalizedResource();

public override string Description
=> "DecompressArchiveDescription".GetLocalizedResource();
=> Strings.DecompressArchiveDescription.GetLocalizedResource();

public override HotKey HotKey
=> new(Keys.E, KeyModifiers.Ctrl);
Expand Down
4 changes: 2 additions & 2 deletions src/Files.App/Actions/Content/Archives/Decompress/DecompressArchiveHere.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@ namespace Files.App.Actions
internal sealed partial class DecompressArchiveHere : BaseDecompressArchiveAction
{
public override string Label
=> "ExtractHere".GetLocalizedResource();
=> Strings.ExtractHere.GetLocalizedResource();

public override string Description
=> "DecompressArchiveHereDescription".GetLocalizedResource();
=> Strings.DecompressArchiveHereDescription.GetLocalizedResource();

public DecompressArchiveHere()
{
Expand Down
4 changes: 2 additions & 2 deletions src/Files.App/Actions/Content/Archives/Decompress/DecompressArchiveHereSmart.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@ namespace Files.App.Actions
internal sealed partial class DecompressArchiveHereSmart : BaseDecompressArchiveAction
{
public override string Label
=> "ExtractHereSmart".GetLocalizedResource();
=> Strings.ExtractHereSmart.GetLocalizedResource();

public override string Description
=> "DecompressArchiveHereSmartDescription".GetLocalizedResource();
=> Strings.DecompressArchiveHereSmartDescription.GetLocalizedResource();

public override HotKey HotKey
=> new(Keys.E, KeyModifiers.CtrlShift);
Expand Down
8 changes: 4 additions & 4 deletions src/Files.App/Actions/Content/Archives/Decompress/DecompressArchiveToChildFolderAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ public override string Label
=> ComputeLabel();

public override string Description
=> "DecompressArchiveToChildFolderDescription".GetLocalizedResource();
=> Strings.DecompressArchiveToChildFolderDescription.GetLocalizedResource();

public DecompressArchiveToChildFolderAction()
{
Expand Down Expand Up @@ -86,11 +86,11 @@ protected override void Context_PropertyChanged(object? sender, PropertyChangedE
private string ComputeLabel()
{
if (context.SelectedItems == null || context.SelectedItems.Count == 0)
return string.Format("BaseLayoutItemContextFlyoutExtractToChildFolder".GetLocalizedResource(), string.Empty);
return string.Format(Strings.BaseLayoutItemContextFlyoutExtractToChildFolder.GetLocalizedResource(), string.Empty);

return context.SelectedItems.Count > 1
? string.Format("BaseLayoutItemContextFlyoutExtractToChildFolder".GetLocalizedResource(), "*")
: string.Format("BaseLayoutItemContextFlyoutExtractToChildFolder".GetLocalizedResource(), SystemIO.Path.GetFileNameWithoutExtension(context.SelectedItems.First().Name));
? string.Format(Strings.BaseLayoutItemContextFlyoutExtractToChildFolder.GetLocalizedResource(), "*")
: string.Format(Strings.BaseLayoutItemContextFlyoutExtractToChildFolder.GetLocalizedResource(), SystemIO.Path.GetFileNameWithoutExtension(context.SelectedItems.First().Name));
}
}
}
Loading