Skip to content

Code Quality: Add IsExecutable check for SearchAction #17646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2025
Merged

Code Quality: Add IsExecutable check for SearchAction #17646

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion src/Files.App/Actions/Global/SearchAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,16 +23,35 @@ public HotKey SecondHotKey
public RichGlyph Glyph
=> new(themedIconStyle: "App.ThemedIcons.Omnibar.Search");

public bool IsExecutable
=> context.ShellPage is not null;

public SearchAction()
{
context = Ioc.Default.GetRequiredService<IContentPageContext>();

context.PropertyChanged += Context_PropertyChanged;
}

public Task ExecuteAsync(object? parameter = null)
{
context.ShellPage!.ToolbarViewModel.SwitchToSearchMode();
// Check if ShellPage is available before executing the action
if (context.ShellPage is null)
return Task.CompletedTask;

context.ShellPage.ToolbarViewModel.SwitchToSearchMode();

return Task.CompletedTask;
}

private void Context_PropertyChanged(object? sender, PropertyChangedEventArgs e)
{
switch (e.PropertyName)
{
case nameof(IContentPageContext.ShellPage):
OnPropertyChanged(nameof(IsExecutable));
break;
}
}
}
}
Loading