Skip to content

Conversation

@workbysaran
Copy link
Contributor

Resolved / Related Issues
Fixed an issue where the context menu displayed inappropriate navigation and action options for items in the Recycle Bin. Since items in the Recycle Bin cannot be properly navigated or used until restored, the following menu items are now hidden when right-clicking Recycle Bin items:

  • "Open in New Tab", "Open in New Window", "Open in New Pane" - Hidden for all items in Recycle Bin
  • "Create Folder with Selection" - Hidden for items in Recycle Bin
  • "Open" - Hidden only for folders in Recycle Bin

Steps used to test these changes

  1. Open the Files app and navigate to any folder
  2. Delete some files and folders to create test items in Recycle Bin
  3. Navigate to the Recycle Bin
  4. Test folder context menu
    • Right-click on a deleted folder in the Recycle Bin
    • Verify that "Open", "Open in New Tab", "Open in New Window", "Open in New Pane", and "Create Folder with Selection" do not appear in the context menu.
  5. Test file context menu
    • Right-click on a deleted file in the Recycle Bin
    • Verify that "Open" is visible and "Create Folder with Selection" do not appear in the context menu.

@yaira2
Copy link
Member

yaira2 commented Oct 30, 2025

Thank you for the PR. Would it be possible to set the IsExecutable property from the actions code? Otherwise, these actions will still be available from the Command Palette.

@yaira2 yaira2 added the changes requested Changes are needed for this pull request label Oct 30, 2025
@yaira2 yaira2 changed the title Fix: Hidden inappropriate context menu items for Recycle Bin. Fix: Fixed an issue where incorrect actions were displayed in the Recycle Bin context menu Oct 30, 2025
@workbysaran
Copy link
Contributor Author

Thank you for the PR. Would it be possible to set the IsExecutable property from the actions code? Otherwise, these actions will still be available from the Command Palette.

Thank you for the feedback! I've updated the code to set the IsExecutable property.

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed changes requested Changes are needed for this pull request labels Nov 3, 2025
@yaira2 yaira2 merged commit 25c59f1 into files-community:main Nov 3, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants