Fix: Ensure newly opened folder column is fully visible in Columns Layout #17826
+15
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaira2
reviewed
Nov 5, 2025
| UpdateLayout(); | ||
| GetScrollViewer()?.ChangeView(_scrollViewer.ScrollableWidth, null, null); | ||
| // The following line doesn't work as expected due to the items not being fully loaded yet and thus the scrollable width not being accurate. | ||
| //GetScrollViewer()?.ChangeView(_scrollViewer.ScrollableWidth, null, null); |
yaira2
added
the
ready to merge
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue with scrolling to the end of a blade view when the scrollable width is not yet accurate. The solution defers scrolling until after the layout is updated, ensuring items are fully loaded.
- Introduced a new
ScrollToEnd()method that waits for layout updates before scrolling - Added a call to
ScrollToEnd()after setting blade width in the columns layout - Commented out the non-working immediate scroll approach in
ItemsVectorChanged
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Files.App.Controls/BladeView/BladeView.cs | Added ScrollToEnd() method with layout-deferred scrolling and commented out immediate scroll that didn't work |
| src/Files.App/Views/Layouts/ColumnsLayoutPage.xaml.cs | Called ScrollToEnd() after setting blade width to ensure scroll happens after layout completes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Fixed an issue where the horizontal scrollbar in Columns Layout did not automatically scroll to show newly opened folder columns, leaving them partially visible.
Closes #17755
Steps used to test these changes