Fix: Fixed an issue with opening shell locations on startup

[yaira2]

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

• Closes Bug: Not a folder error when opening shell addresses #15083

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

1. Set Files as default file manager
2. Changed language to not match the Windows language
3. Fully closed Files
4. Opened Recycle Bin shortcut from desktop

[yaira2]

@gave92 this PR reverts a change you made in #6293. Do you know if this brings back the underlying issue it was originally supposed to solve (I wasn't able to reproduce this issue on my side)?

[gave92]

Hey yair, it seems like removing the code above does not cause #6190 to come back 👍. That said I cannot reproduce issue #15083 so not sure if removeing this fixes the issue. Also you may want to remove the similar logic from InitializeApplicationAsync

// Convert short name to long name (#6190)
unescapedValue = folder.Path;

[yaira2]

@gave92 thank you for checking. The testing steps mentioned in the PR description seem to be an easy way to reproduce the issue.

I'm hesitant to remove the code from InitializeApplicationAsync unless we know of a scenario where it causes issues. Do you know when the line was first added?