Skip to content

Conversation

@workbysaran
Copy link
Contributor

@workbysaran workbysaran commented Nov 21, 2025

Resolved / Related Issues
Fixed an issue where combining tag searches with the NOT operator did not work properly. Additionally enhanced tag search functionality with AND/OR operator support and improved query handling.

Closes #17808

Steps used to test these changes

  1. Search 'tag:Mountain' - returns files with Mountain tag
  2. Search 'tag:Bird' - returns files with Bird tag
  3. Search 'tag:Mountain NOT tag:Bird' - returns files with Mountain but NOT Bird
  4. Search 'NOT tag:Bird' - returns all files without Bird tag
  5. Search 'tag:Mountain AND tag:River' - returns files with both tags
  6. Search 'tag:Mountain OR tag:River' - returns files with either tag
  7. Search 'tag:red,blue' - returns files with red OR blue tags

@yaira2 yaira2 added the ready for review Pull requests that are ready for review label Nov 23, 2025
@yaira2
Copy link
Member

yaira2 commented Nov 23, 2025

Does this also include support for 'AND' and 'OR'?

@workbysaran
Copy link
Contributor Author

No, I have implemented only the NOT functionality.

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 requested a review from 0x5bfa November 26, 2025 17:26
Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code wise, lgtm.

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Nov 27, 2025
@yaira2 yaira2 changed the title Fix: Fixed the issue of tag search NOT operator not working Fix: Fixed the issue where AND OR operators didn't work when searching for tags Nov 27, 2025
@yaira2 yaira2 changed the title Fix: Fixed the issue where AND OR operators didn't work when searching for tags Fix: Fixed an issue where AND OR operators didn't work when searching for tags Nov 27, 2025
@yaira2 yaira2 merged commit 311a0d4 into files-community:main Nov 27, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: AQS Boolean operators (NOT, AND, OR) don’t work with tag: searches

3 participants