Skip to content

Fix: Fixed issue where Third Party Libraries section was cut off#18261

Merged
yair100 merged 4 commits intomainfrom
ya/AboutPage
Mar 15, 2026
Merged

Fix: Fixed issue where Third Party Libraries section was cut off#18261
yair100 merged 4 commits intomainfrom
ya/AboutPage

Conversation

@yair100
Copy link
Copy Markdown
Member

@yair100 yair100 commented Mar 15, 2026

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Confirmed the Third Party Libraries section is no longer cut off.

@yair100 yair100 requested a review from 0x5bfa March 15, 2026 03:40
@yair100 yair100 added the ready for review Pull requests that are ready for review label Mar 15, 2026
Copy link
Copy Markdown
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whats the reason of using ItemsHeader (background missing also)? it's primarily for InfoBar.

Image

@yair100
Copy link
Copy Markdown
Member Author

yair100 commented Mar 15, 2026

Items doesn't work well for this scenario (it's not responsive). We do something similar for the background color option in Appearance Settings.
Thank you for pointing out the background, I'll add that back.

@yair100 yair100 requested a review from 0x5bfa March 15, 2026 14:28
@yair100 yair100 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Mar 15, 2026
@yair100 yair100 merged commit 827e3a6 into main Mar 15, 2026
9 checks passed
@yair100 yair100 deleted the ya/AboutPage branch March 15, 2026 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Misaligned or Cut-Off Third Party Libaries Section in Files > Settings > About

2 participants