Conversation
yair100
force-pushed
the
ya/ActionGroups
branch
4 times, most recently
from
3c4632e to
ffffe07
Compare
yair100
force-pushed
the
ya/ActionGroups
branch
from
ffffe07 to
cab9938
Compare
0x5bfa
approved these changes
Mar 17, 2026
Member
0x5bfa
left a comment
0x5bfa
left a comment
There was a problem hiding this comment.
Overall looks good to me. Bad that there's no ItemsSource in MenuFlyout for us to bind properties.
| using Microsoft.UI.Xaml; | ||
| using Microsoft.UI.Xaml.Controls; | ||
|
|
||
| namespace Files.App.Actions; |
Member
There was a problem hiding this comment.
Better to put this (preferably separating each class) in https://github.com/files-community/Files/tree/main/src/Files.App/Data/Commands/Manager
|
|
||
| namespace Files.App.Actions; | ||
|
|
||
| public sealed class CommandGroups |
Member
There was a problem hiding this comment.
Preferably CommandGroupManager with namespace Files.App.Data.Commands
Member
Author
It would be nice, agreed. |
0x5bfa
approved these changes
Mar 17, 2026
yair100
added
ready to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
More work is needed to apply these changes, but I don't want to complicate this PR.
Steps used to test these changes
Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.
main.