Skip to content

Feature: Replaced Settings Dialog with page#18410

Merged
yair100 merged 3 commits intomainfrom
ya/SettingsPageSwitch
Apr 23, 2026
Merged

Feature: Replaced Settings Dialog with page#18410
yair100 merged 3 commits intomainfrom
ya/SettingsPageSwitch

Conversation

@yair100
Copy link
Copy Markdown
Member

@yair100 yair100 commented Apr 22, 2026

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

  • Closes #

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Opened Files ...
  2. ...

@yair100 yair100 marked this pull request as draft April 22, 2026 21:34
@yair100 yair100 force-pushed the ya/SettingsPageSwitch branch from ce3f45c to 08a2366 Compare April 23, 2026 00:06
@yair100 yair100 marked this pull request as ready for review April 23, 2026 00:07
@yair100 yair100 force-pushed the ya/SettingsPageSwitch branch from 8f766bc to b0559e2 Compare April 23, 2026 02:11
@yair100 yair100 force-pushed the ya/SettingsPageSwitch branch from b0559e2 to bf716b2 Compare April 23, 2026 02:40
@yair100 yair100 requested a review from 0x5bfa April 23, 2026 14:31
Copy link
Copy Markdown
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code wise, looks good to me.

@yair100 yair100 added the ready to merge Pull requests that are approved and ready to merge label Apr 23, 2026
@yair100 yair100 merged commit 65e4bf8 into main Apr 23, 2026
14 of 15 checks passed
@yair100 yair100 deleted the ya/SettingsPageSwitch branch April 23, 2026 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants