Skip to content

Conversation

@gave92
Copy link
Member

@gave92 gave92 commented Sep 9, 2022

Resolved / Related Issues
Items resolved / related issues by this PR.

  • Fixes dragging the window on windows 10

Despite the docs, SetDragRectangles() still does not work on win10 with winappsdk "1.2.220902.1-preview1" :/
Confirmed on Discord.
The workaround is kinda ugly, if you prefer to just wait for a fix from winappsdk I'm ok to not merge this. Does not change things on win11.

Validation
How did you test these changes?

  • Built and ran the app

@gave92 gave92 requested a review from yaira2 September 9, 2022 21:21
@gave92 gave92 added the ready for review Pull requests that are ready for review label Sep 9, 2022
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Sep 9, 2022
@yaira2 yaira2 merged commit c0aeec5 into files-community:main Sep 9, 2022
@gave92 gave92 deleted the win10fix branch September 9, 2022 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants