Close service when prepared query can't be parsed #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue wherein the service isn't closed when the parse phase of a prepared statement fails. This causes that connection to hang. Instead, the parse failure should cause the service to be closed (just as the successful completion of the query closes the service, and the failure at any other point during the process does the same).
| parse(sql, Some(service)).map { name => | ||
| new PreparedStatementImpl(name, service) | ||
| }.onFailure { | ||
| err => service.close() |
Collaborator
There was a problem hiding this comment.
Shouldn't' we just close it anyway (no matter if it's a failure or success)?
.ensure(service.close())
Collaborator
Author
There was a problem hiding this comment.
You can't close it at this point if it's a success, because the service still has more phases to execute after Parse.
Collaborator
Author
There was a problem hiding this comment.
The PreparedStatementImpl needs to use the same service that Parse was executed on (because that session is where the prepared statement lives)
Sync needs to be issued on the connection before the service is closed. Also, prepareAndExecute needs the same treatment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue wherein the service isn't closed when the parse
phase of a prepared statement fails. This causes that connection to
hang. Instead, the parse failure should cause the service to be closed
(just as the successful completion of the query closes the service, and
the failure at any other point during the process does the same).