Fix error syncing #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I did this because currently, if there's an error during an extended query message flow, we must issue a `Sync` in order to get Postgres to respond to any further messages. However, the state machine currently does not allow for a Sync message in any state but `Connected`. This results in a connection hang in some situations. This change allows `Sync` during any of the extended query states.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did this because currently, if there's an error during an extended
query message flow, we must issue a
Syncin order to get Postgres torespond to any further messages. However, the state machine currently
does not allow for a Sync message in any state but
Connected. Thisresults in a connection hang in some situations.
This change allows
Syncduring any of the extended query states.