Converted to stack-based client #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removed `postgres.Client.apply` * Added `Postgres.Client()` with stack-based config API * Added explicit close() on ChannelClosedException (from behind load balancer)
vkostyukov
requested changes
Nov 1, 2016
Collaborator
vkostyukov
left a comment
vkostyukov
left a comment
There was a problem hiding this comment.
Thanks a lot @jeremyrsmith!
This looks great! I'm super happy to see finagle-postgres evolving. Thanks to you, it's now one step closer to the Netty 4 support!
|
|
||
| def withBinaryParams(enable: Boolean = true) = configured(BinaryParams(enable)) | ||
| def withBinaryResults(enable: Boolean = true) = configured(BinaryResults(enable)) | ||
| def database(database: String) = configured(Database(database)) |
| } | ||
| } | ||
|
|
||
| def dest(name: Name): Client = configured(Dest(name)) |
Collaborator
There was a problem hiding this comment.
I don't think you need this. Dest passed as part of newService call.
| def database(database: String) = configured(Database(database)) | ||
| def withCustomTypes(customTypes: Map[Int, postgres.Client.TypeSpecifier]) = | ||
| configured(CustomTypes(Some(customTypes))) | ||
| def withDefaultTypes() = configured(CustomTypes(Some(postgres.Client.defaultTypes))) |
| id: String, | ||
| useSsl: Boolean, | ||
| trustManagerFactory: TrustManagerFactory = InsecureTrustManagerFactory.INSTANCE | ||
| ) extends CodecFactory[PgRequest, PgResponse] { |
Collaborator
There was a problem hiding this comment.
I'm so happy to see this!
| // because postgres doesn't start out in TLS | ||
| ) | ||
|
|
||
| case class Client( |
Collaborator
There was a problem hiding this comment.
We usually provide a default instance:
val client = Client() // and then
val c = Postgres.client.with...
``| type In = PgRequest | ||
| type Out = PgResponse | ||
|
|
||
| def newRichClient(): postgres.Client = { |
Collaborator
There was a problem hiding this comment.
You can have newRichClient taking Name instead of grabbing it from stack params.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
postgres.Client.applyPostgres.Client()with stack-based config API