Aggregate refined#969
Conversation
|
Oh that's a good catch. Thanks @rider-yi! CI fails with the following error on 2.11: Do you have any idea why? I restarted the job just in case. |
|
@vkostyukov I think its Scala 2.11 v 2.12 related. Pretty sure |
|
I see. Sounds like we never compiled it for 2.11 hence never saw an error. Importing Cats' syntax works for me, fwiw. @rider-yi any chance you want to fix this as part of this PR? |
Codecov Report
@@ Coverage Diff @@
## master #969 +/- ##
==========================================
+ Coverage 83.47% 83.57% +0.09%
==========================================
Files 50 52 +2
Lines 835 840 +5
Branches 44 44
==========================================
+ Hits 697 702 +5
Misses 138 138
Continue to review full report at Codecov.
|
|
I just fixed the error with RightProjection. It seems that importing Cats's syntax causes unused warning: |
|
Changes look good to me! Thanks again, @rider-yi! |
I just noticed that the new
finch-refinedmodule wasn't being published.