Update example to support both Finch and Circe accumulated errors#970
Merged
Conversation
…Circe accumulated errors
Codecov Report
@@ Coverage Diff @@
## master #970 +/- ##
==========================================
+ Coverage 83.53% 83.57% +0.03%
==========================================
Files 52 52
Lines 838 840 +2
Branches 44 44
==========================================
+ Hits 700 702 +2
Misses 138 138
Continue to review full report at Codecov.
|
vkostyukov
approved these changes
Jul 27, 2018
Collaborator
vkostyukov
left a comment
vkostyukov
left a comment
There was a problem hiding this comment.
Thanks @rpless! This LGTM.
Collaborator
|
Cherry-picked into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the Circe Exception Encoder handle accumulated errors.
Also the docs failing to compile with
docs/makeMicrositesomething about importingPerson._was breaking them. I pulled those codecs out of the companion object to get it to compile. I'm open to alternatives for fixing that.