Skip to content

README: trim install section, add Windows#121

Merged
droid-ash merged 1 commit intomainfrom
docs/readme-install-trim
Apr 26, 2026
Merged

README: trim install section, add Windows#121
droid-ash merged 1 commit intomainfrom
docs/readme-install-trim

Conversation

@droid-ash
Copy link
Copy Markdown
Contributor

Summary

Trims the README install section from ~14 lines to 6, and adds Windows install instructions (which were missing entirely — v0.1.10 shipped install.ps1 but the README never mentioned it).

What changed

Before (lines 52-68):

  • Install command for macOS/Linux only
  • A 60-word paragraph describing what install.sh does internally (binary location, PATH, runtime tarball, prompts, host tools, skills, "no Node.js required")
  • A separate --ci install block with explanation
  • A line about CI=1 env auto-detect
  • A "run finalrun doctor" tip

After:

  • Install command for macOS/Linux
  • Install command for Windows (PowerShell)
  • One sentence on the iOS-on-Windows constraint
  • One link to the release notes for CI flags / env overrides / artifact list

Why these details belong elsewhere (and already do)

Removed content Where it already lives
"Downloads a self-contained binary into ~/.finalrun/bin/, adds it to PATH, prompts for Android/iOS, installs host tools…" scripts/install.sh header comment block (lines 1-18) and .github/release-notes-template.md (auto-included on every GitHub Release page)
--ci flag + CI=1 auto-detect .github/release-notes-template.md (the user reads this when downloading) and install.sh --help
"After install, run finalrun doctor" finalrun --help lists doctor as a top-level command; troubleshooting docs go deeper

The README's job at "Install" is "get me started in one command per OS." Implementation details belong with the implementation.

What I kept

The iOS-on-Windows clarifier:

iOS local testing requires macOS (xcodebuild). On Windows, use finalrun cloud for iOS — Android works locally.

This preempts the most common "why doesn't iOS work on Windows?" question. The release notes mention it too, but the README is where someone evaluates the tool before clicking through to releases — having the constraint visible at evaluation time avoids a wasted install.

Test plan

  • Render the README on GitHub and verify both install blocks display correctly
  • Click the "latest release notes" link and confirm it lands on the v0.1.10 release page (or whatever's latest)
  • Confirm no other README sections were touched

Why a separate PR

Docs-only, no version bump, no release workflow. Lands directly on main and is immediately live. Keeping this isolated from v0.1.10's release commit makes the diff focused on one judgment call (what to keep vs trim) rather than mixing docs taste with release mechanics.

🤖 Generated with Claude Code

The install section was carrying details that belong elsewhere:

  - "Downloads a self-contained finalrun binary into ~/.finalrun/bin/,
    adds it to your PATH, downloads the per-platform runtime tarball,
    prompts for Android/iOS, installs host tools..." — internals of
    install.sh, already documented in the script's header comment and
    in the auto-generated release notes (.github/release-notes-template.md).
  - "For CI / non-interactive environments..." — CI flag and env-var
    documentation, already in release notes and install.sh's --help.
  - "After install, run finalrun doctor..." — diagnostic guidance that
    fits better in finalrun --help / docs/troubleshooting.md.

A README install block should answer "how do I get this on my machine"
in one or two commands, not document the installer's behavior. Trimmed
to just the install one-liners per platform plus a single sentence on
the iOS-on-Windows constraint (preempts the most common support
question without expanding the section).

Adds Windows install instructions for the first time. Until v0.1.10,
the .ps1 installer didn't exist; v0.1.10 shipped it (commit 9d5b78e on
PR #120) and the .exe / runtime tarball are now on every release. The
README continues to point only at install.sh and ignores Windows —
this catches it up.

Net: 14 lines → 6 lines, +1 platform.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 26, 2026

Warning

Rate limit exceeded

@droid-ash has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 24 minutes and 7 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 24 minutes and 7 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: cf601ba0-2145-4fc7-8856-030b5778075b

📥 Commits

Reviewing files that changed from the base of the PR and between 89fcbb4 and 36f56d3.

📒 Files selected for processing (1)
  • README.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/readme-install-trim

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@droid-ash droid-ash self-assigned this Apr 26, 2026
@droid-ash droid-ash merged commit ff57e96 into main Apr 26, 2026
2 checks passed
@droid-ash droid-ash added the documentation Improvements or additions to documentation label Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant