Skip to content

Conversation

@Nick-Mazuk
Copy link
Member

@Nick-Mazuk Nick-Mazuk commented Aug 10, 2022

We've had two threads on naming scripts. I think we're in consensus on at least the basics of naming scripts. So I'm adding what we agreed upon to the docs.

Fix #313
Fix #270

Looking for a LGTM from both @rpatters1 and @cv-on-hub before merging to ensure we're in agreement. Merging this PR will close the related issues. Feel free to merge without me once both of you LGTM.

@cv-on-hub
Copy link
Contributor

I suggest, "A script's name" should become "A script's name as returned by plugindef()", and we seem to agree on Capital Case for script names appearing in Finale menus.

The "Use a consistent file name" section remains solid and agrees with my previous assumption about: "take things from general to specific"

Copy link
Collaborator

@rpatters1 rpatters1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Contributor

@cv-on-hub cv-on-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM also

@Nick-Mazuk Nick-Mazuk merged commit 8930e60 into master Aug 10, 2022
@Nick-Mazuk Nick-Mazuk deleted the script-names branch August 10, 2022 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Capitalization Rules for Menu Items Naming scripts

4 participants