Call .onLoad during package loading#10
Merged
Merged
Conversation
Agent-Logs-Url: https://github.com/finccam/loadfast/sessions/d3948ef7-86a3-4121-934b-a689c1177daf Co-authored-by: ak-finccam <266784444+ak-finccam@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update loadfast to call .onLoad during package loading
Call Apr 10, 2026
.onLoad during package loading
felix-andreas-finccam
approved these changes
Apr 14, 2026
ak-finccam
approved these changes
Apr 14, 2026
Contributor
|
@felix-andreas-finccam Ich würde das hier dann mergen, richtig? |
Contributor
|
hab's gemergt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
loadfastwas not calling.onLoadhooks (typically defined inzzz.R), unlikedevtools::load_all()and normal R package loading. Packages relying on.onLoadfor initialization (options, registrations, connections, etc.) would silently skip that setup.Changes
.loadfast.run_onload()helper — callsns_env$.onLoad(dirname(abs_path), pkg_name)if defined, matching standard R argument convention; errors are downgraded to warnings.onLoadfires after exports are set and testthat is attached, but beforeattach()— matching standard R ordering (.onLoadbefore.onAttach).onLoadfires after changed files are re-sourced and pkg env is synced; skipped on the no-change short-circuitlibname/pkgnamearguments, suppression on no-change reload, and re-invocation on incremental reloadExample
Previously
load_fast()would ignore this; now it is called on every load that sources files.