fix: maintain fractional part of DateTime when formatting#226
Merged
Conversation
- Update `ObjectSerializer.mustache` to use the RFC3339_EXTENDED format to maintain the fractional part (i.e., the milliseconds) of the DateTime when formatting it as a string. This allows a DateTime to be created with milliseconds and have it be maintained when sending as a query parameter.
Contributor
|
🟢 Coverage increased by 83.98% Code Coverage ReportCoverage Report
Files Coverage
|
mcnulty-fp
requested review from
Orkuncakilkaya,
TheUnderScorer,
erayaydin and
ilfa
as code owners
erayaydin
previously approved these changes
May 20, 2026
Member
erayaydin
left a comment
erayaydin
left a comment
There was a problem hiding this comment.
LGTM. Thanks for fixing this issue ❤️
Contributor
🚀 Following releases will be created using changesets from this PR:@fingerprint/php-sdk@7.2.0-beta.2Patch Changes
|
erayaydin
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ObjectSerializer.mustacheto use the RFC3339_EXTENDED format to maintain the fractional part (i.e., the milliseconds) of the DateTime when formatting it as a string. This allows a DateTime to be created with milliseconds and have it be maintained when sending as a query parameter.