✅ [just] v3.9 fixes shellcheck errors in gh-process

[chicks-net]

Done

• ✅ [just] v3.9 fixes shellcheck errors in gh-process

Meta

(Automated in .just/gh-process.just.)

[Copilot]

Pull Request Overview

This PR updates the gh-process.just file to fix shellcheck errors, improving script quality and reliability. The changes modernize bash scripting practices by adopting recommended patterns for variable handling and command substitution.

Key Changes:

• Replaced deprecated backtick command substitution with modern $() syntax
• Added proper quoting around variables to prevent word splitting issues
• Refactored file writing to use command grouping with proper redirection

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[claude]

Code Review - PR #40

Summary

This PR addresses shellcheck errors in .just/gh-process.just by fixing several shell scripting best practices. The changes improve code quality and eliminate shellcheck warnings.

Positive Changes ✅

1. Proper variable quoting (.just/gh-process.just:145-147, 150)

   • Changed PR_META, PR_REPO_OWNER, PR_REPO_NAME, PR_NUMBER variables to use double quotes
   • Prevents word splitting and glob expansion issues
   • Best practice for shell scripting safety

2. Command substitution modernization (.just/gh-process.just:75)

   • Changed backticks to modern command substitution syntax
   • Modern POSIX syntax, easier to nest, more readable
   • Eliminates SC2006 shellcheck warning

3. Heredoc pattern for file writes (.just/gh-process.just:39-47)

   • Replaced multiple >> redirects with a single grouped command block
   • More efficient (opens file once instead of multiple times)
   • Eliminates SC2129 shellcheck warning
   • Better atomic write pattern

4. Quote consistency (.just/gh-process.just:47)

   • Added proper quoting to bodyfile variable reference
   • Consistent with best practices throughout

5. Shellcheck directive (.just/gh-process.just:149)

   • Added shellcheck disable comment for the GraphQL query
   • Appropriate use since single quotes in the GraphQL query are intentional
   • Documents the exception clearly

Code Quality Assessment

No bugs identified - All changes are improvements to existing functionality without behavioral changes.

Performance - The heredoc pattern (lines 39-47) is actually more efficient than the previous implementation since it only opens the file descriptor once.

Security - The variable quoting improvements enhance security by preventing injection vulnerabilities through word splitting.

Best Practices - All changes align with ShellCheck recommendations and modern bash scripting standards.

Test Coverage

The changes are refactoring-only and do not alter logic, so existing test coverage should be sufficient. The shellcheck automation itself serves as validation.

Recommendations

Ready to merge - This is a clean shellcheck compliance fix with no concerns.

Optional future enhancement: Consider adding strict mode (set -euo pipefail) to the pr recipe script (line 19) for consistency with the shellcheck recipe, but this is not required for this PR.

---

Great work on maintaining code quality through automated tooling! 🎯