Fdc3 for web impl fixes rm

[robmoffat]

Describe your change

Related Issue

Contributor License Agreement

• I acknowledge that a contributor license agreement is required and that I have one in place or will seek to put one in place ASAP.

Review Checklist

• Issue: If a change was made to the FDC3 Standard, was an issue linked above?
• CHANGELOG: Is a CHANGELOG.md entry included?
• API changes: Does this PR include changes to any of the FDC3 APIs (DesktopAgent, Channel, PrivateChannel, Listener, Bridging)?
  • Docs & Sources: If yes, were both documentation (/docs) and sources updated?
    
    JSDoc comments on interfaces and types should be matched to the main documentation in /docs
  • Conformance tests: If yes, are conformance test definitions (/toolbox/fdc3-conformance) still correct and complete?
    
    Conformance test definitions should cover all required aspects of an FDC3 Desktop Agent implementation, which are usually marked with a MUST keyword, and optional features (SHOULD or MAY) where the format of those features is defined
  • Schemas: If yes, were changes applied to the Bridging and FDC3 for Web protocol schemas?
    
    The Web Connection protocol and Desktop Agent Communication Protocol schemas must be able to support all necessary aspects of the Desktop Agent API, while Bridging must support those aspects necessary for Desktop Agents to communicate with each other
    • If yes, was code generation (npm run build) run and the results checked in?
      
      Generated code will be found at /src/api/BrowserTypes.ts and/or /src/bridging/BridgingTypes.ts
• Context types: Were new Context type schemas created or modified in this PR?
  • Were the field type conventions adhered to?
  • Was the BaseContext schema applied via allOf (as it is in existing types)?
  • Was a title and description provided for all properties defined in the schema?
  • Was at least one example provided?
  • Was code generation (npm run build) run and the results checked in?
    
    Generated code will be found at /src/context/ContextTypes.ts
• Intents: Were new Intents created in this PR?
  • Were the intent name prefixes and other naming conventions & characteristics adhered to?
  • Was the new intent added to the list in the Intents Overview?

[github-actions]

[github-actions]

Coverage Report

Commit: 7445181
Base: fdc3-for-web-impl@3f1bc53

Type	Base	This PR
Total Statements Coverage	97.32%	97.33% (+0.01%)
Total Branches Coverage	86.09%	86.09% (+0%)
Total Functions Coverage	98.07%	97.04% (-1.03%)
Total Lines Coverage	97.33%	97.34% (+0.01%)

Details (changed files)

File	Statements	Branches	Functions	Lines
packages/fdc3-get-agent/src/index.ts	100%	100%	28.57%	100%

Details (all files)

File	Statements	Branches	Functions	Lines
packages/fdc3-agent-proxy/src/DesktopAgentProxy.ts	100%	100%	100%	100%
packages/fdc3-agent-proxy/src/index.ts	100%	100%	71.42%	100%
packages/fdc3-agent-proxy/src/util.ts	100%	100%	100%	100%
packages/fdc3-agent-proxy/src/apps/DefaultAppSupport.ts	86.36%	50%	100%	86.36%
packages/fdc3-agent-proxy/src/channels/DefaultChannel.ts	100%	100%	100%	100%
packages/fdc3-agent-proxy/src/channels/DefaultChannelSupport.ts	100%	100%	100%	100%
packages/fdc3-agent-proxy/src/channels/DefaultPrivateChannel.ts	97.29%	66.66%	100%	97.29%
packages/fdc3-agent-proxy/src/heartbeat/DefaultHeartbeatSupport.ts	100%	100%	100%	100%
packages/fdc3-agent-proxy/src/intents/DefaultIntentResolution.ts	100%	100%	100%	100%
packages/fdc3-agent-proxy/src/intents/DefaultIntentSupport.ts	100%	100%	100%	100%
packages/fdc3-agent-proxy/src/listeners/AbstractListener.ts	100%	60%	100%	100%
packages/fdc3-agent-proxy/src/listeners/DefaultContextListener.ts	100%	90%	100%	100%
packages/fdc3-agent-proxy/src/listeners/DefaultIntentListener.ts	100%	77.77%	100%	100%
packages/fdc3-agent-proxy/src/listeners/EventListener.ts	100%	100%	100%	100%
packages/fdc3-agent-proxy/src/listeners/HeartbeatListener.ts	100%	100%	100%	100%
packages/fdc3-agent-proxy/src/listeners/PrivateChannelEventListener.ts	93.18%	72.72%	100%	93.18%
packages/fdc3-agent-proxy/src/messaging/AbstractMessaging.ts	93.33%	100%	80%	93.33%
packages/fdc3-get-agent/src/index.ts	100%	100%	28.57%	100%
packages/fdc3-get-agent/src/messaging/MessagePortMessaging.ts	100%	100%	100%	100%
packages/fdc3-get-agent/src/messaging/message-port.ts	97.43%	93.33%	100%	97.43%
packages/fdc3-get-agent/src/sessionStorage/DesktopAgentDetails.ts	97.36%	89.47%	100%	97.36%
packages/fdc3-get-agent/src/strategies/DesktopAgentPreloadLoader.ts	100%	81.25%	100%	100%
packages/fdc3-get-agent/src/strategies/FailoverHandler.ts	100%	80%	100%	100%
packages/fdc3-get-agent/src/strategies/HelloHandler.ts	93.75%	75%	100%	93.75%
packages/fdc3-get-agent/src/strategies/IdentityValidationHandler.ts	95.65%	73.33%	100%	95.65%
packages/fdc3-get-agent/src/strategies/PostMessageLoader.ts	98.43%	85.71%	100%	98.41%
packages/fdc3-get-agent/src/strategies/getAgent.ts	100%	100%	100%	100%
packages/fdc3-get-agent/src/ui/AbstractUIComponent.ts	97.14%	71.42%	100%	97.01%
packages/fdc3-get-agent/src/ui/DefaultDesktopAgentChannelSelector.ts	100%	75%	100%	100%
packages/fdc3-get-agent/src/ui/DefaultDesktopAgentIntentResolver.ts	100%	90%	100%	100%
packages/fdc3-get-agent/src/ui/NullChannelSelector.ts	100%	100%	100%	100%
packages/fdc3-get-agent/src/ui/NullIntentResolver.ts	100%	100%	66.66%	100%
packages/fdc3-get-agent/src/util/Logger.ts	100%	73.33%	100%	100%
packages/fdc3-get-agent/src/util/Uuid.ts	100%	100%	100%	100%
packages/fdc3-standard/src/index.ts	100%	100%	0%	100%
packages/fdc3-standard/src/api/Errors.ts	100%	100%	100%	100%
packages/fdc3-standard/src/api/GetAgent.ts	100%	100%	100%	100%
packages/fdc3-standard/src/api/Methods.ts	94.04%	84.05%	96.29%	95%
packages/fdc3-standard/src/api/RecommendedChannels.ts	100%	100%	100%	100%
packages/fdc3-standard/src/context/ContextType.ts	100%	100%	100%	100%
packages/fdc3-standard/src/intents/Intents.ts	100%	100%	100%	100%
packages/fdc3-standard/src/internal/contextConfiguration.ts	100%	100%	100%	100%
packages/fdc3-standard/src/internal/intentConfiguration.ts	100%	100%	100%	100%
packages/fdc3-standard/src/internal/typeHelpers.ts	100%	100%	100%	100%
toolbox/fdc3-for-web/fdc3-web-impl/src/BasicFDC3Server.ts	100%	100%	100%	100%
toolbox/fdc3-for-web/fdc3-web-impl/src/ServerContext.ts	100%	100%	100%	100%
toolbox/fdc3-for-web/fdc3-web-impl/src/directory/BasicDirectory.ts	96.87%	84.21%	100%	96.55%
toolbox/fdc3-for-web/fdc3-web-impl/src/handlers/BroadcastHandler.ts	96.38%	86.41%	100%	96.12%
toolbox/fdc3-for-web/fdc3-web-impl/src/handlers/HeartbeatHandler.ts	88.23%	71.87%	86.66%	90%
toolbox/fdc3-for-web/fdc3-web-impl/src/handlers/IntentHandler.ts	95.6%	86.56%	100%	95%
toolbox/fdc3-for-web/fdc3-web-impl/src/handlers/OpenHandler.ts	97.14%	86.84%	100%	97.14%
toolbox/fdc3-for-web/fdc3-web-impl/src/handlers/support.ts	100%	100%	100%	100%

[kriswest]

LGTM

[kriswest]

@robmoffat The new exports will only be from the fdc3-get-agent module as they are not reexported by the @finos/fdc3 module - but I think thats as it should be as they are only relevant to a DA implementor and not app devs.