Allow retrieving user channels as app channels#1835
Merged
Conversation
✅ Deploy Preview for fdc3 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1835 +/- ##
==========================================
+ Coverage 95.65% 95.68% +0.02%
==========================================
Files 69 69
Lines 4631 4631
Branches 714 772 +58
==========================================
+ Hits 4430 4431 +1
+ Misses 201 200 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Conflicts resolved in changelog, necessitating another review approval |
Contributor
Author
|
@finos/fdc3-maintainers pls approve |
Contributor
Author
|
thanks again @mistryvinay and @kemerava |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change
Fixes a check in fdc3-web-impl that was stopping user channels being retrieved via
fdc3.getCurrentChannel()orfdc3.getOrCreateChannel(<channel-id>).It also corrects an incorrectly prepared
getOrCreateChannelResponsemessage that was using an enum for the channel type instead of the corresponding string (this did not seem to cause an issue but needed to be fixed regardless).Related Issue
resolves #1834
Contributor License Agreement
Review Checklist