Skip to content

Allow retrieving user channels as app channels#1835

Merged
kriswest merged 5 commits intomainfrom
allow-retrieving-user-channels-as-app-channels
Apr 13, 2026
Merged

Allow retrieving user channels as app channels#1835
kriswest merged 5 commits intomainfrom
allow-retrieving-user-channels-as-app-channels

Conversation

@kriswest
Copy link
Copy Markdown
Contributor

@kriswest kriswest commented Apr 9, 2026

Describe your change

Fixes a check in fdc3-web-impl that was stopping user channels being retrieved via fdc3.getCurrentChannel() or fdc3.getOrCreateChannel(<channel-id>).

It also corrects an incorrectly prepared getOrCreateChannelResponse message that was using an enum for the channel type instead of the corresponding string (this did not seem to cause an issue but needed to be fixed regardless).

Related Issue

resolves #1834

Contributor License Agreement

  • I acknowledge that a contributor license agreement is required and that I have one in place or will seek to put one in place ASAP.

Review Checklist

  • Issue: If a change was made to the FDC3 Standard, was an issue linked above?
  • CHANGELOG: Is a CHANGELOG.md entry included?

@kriswest kriswest requested a review from a team as a code owner April 9, 2026 14:10
@netlify
Copy link
Copy Markdown

netlify bot commented Apr 9, 2026

Deploy Preview for fdc3 ready!

Name Link
🔨 Latest commit fafabb9
🔍 Latest deploy log https://app.netlify.com/projects/fdc3/deploys/69d94ff8c5b9db00086364b7
😎 Deploy Preview https://deploy-preview-1835.preview-fdc3.finos.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.68%. Comparing base (c0f0e95) to head (fafabb9).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1835      +/-   ##
==========================================
+ Coverage   95.65%   95.68%   +0.02%     
==========================================
  Files          69       69              
  Lines        4631     4631              
  Branches      714      772      +58     
==========================================
+ Hits         4430     4431       +1     
+ Misses        201      200       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kriswest kriswest added this to the 2.2.2 milestone Apr 9, 2026
kemerava
kemerava previously approved these changes Apr 10, 2026
Copy link
Copy Markdown
Contributor

@kemerava kemerava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kriswest
Copy link
Copy Markdown
Contributor Author

Conflicts resolved in changelog, necessitating another review approval

@kriswest kriswest requested a review from a team April 11, 2026 10:21
@kriswest
Copy link
Copy Markdown
Contributor Author

@finos/fdc3-maintainers pls approve

Copy link
Copy Markdown
Contributor

@mistryvinay mistryvinay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kriswest kriswest merged commit 70af539 into main Apr 13, 2026
7 checks passed
@kriswest kriswest deleted the allow-retrieving-user-channels-as-app-channels branch April 13, 2026 11:00
@kriswest
Copy link
Copy Markdown
Contributor Author

thanks again @mistryvinay and @kemerava

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fdc3-web-impl does not allow a user channel to be retrieved as an app channel

4 participants