Skip to content

Conversation

@jescalada
Copy link
Contributor

@jescalada jescalada commented Nov 28, 2025

Fixes #1285. Based on #1202, would love to get that one merged first!

jescalada and others added 30 commits August 24, 2025 09:39
Co-authored-by: j-k <dev@j-k.io>
Signed-off-by: Juan Escalada <97265671+jescalada@users.noreply.github.com>
Co-authored-by: j-k <dev@j-k.io>
Signed-off-by: Juan Escalada <97265671+jescalada@users.noreply.github.com>
Co-authored-by: j-k <dev@j-k.io>
Signed-off-by: Juan Escalada <97265671+jescalada@users.noreply.github.com>
Co-authored-by: j-k <dev@j-k.io>
Signed-off-by: Juan Escalada <97265671+jescalada@users.noreply.github.com>
jescalada and others added 20 commits November 20, 2025 10:41
Co-authored-by: Kris West <kristopher.west@natwest.com>
Signed-off-by: Juan Escalada <97265671+jescalada@users.noreply.github.com>
Co-authored-by: Kris West <kristopher.west@natwest.com>
Signed-off-by: Juan Escalada <97265671+jescalada@users.noreply.github.com>
Co-authored-by: Kris West <kristopher.west@natwest.com>
Signed-off-by: Juan Escalada <97265671+jescalada@users.noreply.github.com>
@netlify
Copy link

netlify bot commented Nov 28, 2025

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit b372027
🔍 Latest deploy log https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/692bec4acf6e3c00075a5956

@github-actions github-actions bot added the fix label Nov 28, 2025
@codecov
Copy link

codecov bot commented Nov 28, 2025

Codecov Report

❌ Patch coverage is 73.39450% with 58 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.02%. Comparing base (9f24d3f) to head (b372027).

Files with missing lines Patch % Lines
src/service/routes/push.ts 70.14% 20 Missing ⚠️
src/service/routes/auth.ts 77.64% 19 Missing ⚠️
src/service/routes/users.ts 14.28% 6 Missing ⚠️
src/proxy/index.ts 50.00% 5 Missing ⚠️
src/config/index.ts 33.33% 4 Missing ⚠️
...roxy/processors/push-action/checkCommitMessages.ts 92.59% 1 Missing and 1 partial ⚠️
src/service/routes/utils.ts 80.00% 2 Missing ⚠️

❌ Your patch check has failed because the patch coverage (73.39%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1293      +/-   ##
==========================================
- Coverage   83.35%   81.02%   -2.34%     
==========================================
  Files          70       65       -5     
  Lines        3004     4532    +1528     
  Branches      499      775     +276     
==========================================
+ Hits         2504     3672    +1168     
- Misses        397      845     +448     
+ Partials      103       15      -88     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jescalada
Copy link
Contributor Author

I double-checked that the frontend status code handlers are still working. Since we removed a bunch of false 401 errors, most of these would get caught by the generic handler instead.

Of course, we should make these more descriptive by showing the actual error message and status code and removing the callback-based error handling entirely. This is captured in #1188

@jescalada jescalada requested review from a team and kriswest November 30, 2025 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve endpoint status codes (/src/service/routes)

1 participant