-
Notifications
You must be signed in to change notification settings - Fork 149
feat: Add reject reason #1295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
andypols
wants to merge
12
commits into
finos:main
Choose a base branch
from
andypols:add-reject-reason
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: Add reject reason #1295
+910
−196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1295 +/- ##
==========================================
- Coverage 83.35% 80.45% -2.91%
==========================================
Files 70 72 +2
Lines 3004 3162 +158
Branches 499 539 +40
==========================================
+ Hits 2504 2544 +40
- Misses 397 516 +119
+ Partials 103 102 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses #1030. Previously, push rejections were recorded without any context. Reviewers now must provide an explanation when rejecting a push, and that explanation is stored and displayed so contributors can understand why their changes were not approved.
Solution
Backend
db.reject(file and Mongo) to accept a rejection object.Actionvia a newrejectionproperty./push/:id/rejectto require a rejection reason.UI
PushDetailsinto smaller components for clarity and easier maintenance:PushStatusHeaderStatusIconAttestationRejectionApprovalBadgeRejectionBadgeRejectionBadgeandApprovalBadgecomponents to display: