Skip to content

ci: add Windows to test matrix and fix cross-platform compatibility#1361

Open
fabiovincenzi wants to merge 22 commits intofinos:mainfrom
fabiovincenzi:windows-failing-tests
Open

ci: add Windows to test matrix and fix cross-platform compatibility#1361
fabiovincenzi wants to merge 22 commits intofinos:mainfrom
fabiovincenzi:windows-failing-tests

Conversation

@fabiovincenzi
Copy link
Contributor

@fabiovincenzi fabiovincenzi commented Jan 23, 2026

Fixes: #1318.
This PR adds Windows to the CI test matrix and fixes cross-platform compatibility issues.

CI Changes

  • Add windows-latest to the OS matrix
  • Enable Windows Developer Mode in CI for npm symlinks support
  • Skip Cypress e2e tests on Windows
  • Remove unnecessary MongoDB dependency and version matrix (see below)

Cross-Platform Fixes

  • Replace bash script fix-shebang.sh with Node.js fix-shebang.js
  • Add cross-env package for Windows-compatible environment variables in npm scripts

The preReceive tests are skipped because they test Unix shell hook execution, which is not applicable on Windows.

@netlify
Copy link

netlify bot commented Jan 23, 2026

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit 65c45bd
🔍 Latest deploy log https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/69846fb82b6135000769741f

@codecov
Copy link

codecov bot commented Jan 23, 2026

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.26%. Comparing base (2150064) to head (65c45bd).

Files with missing lines Patch % Lines
src/proxy/processors/push-action/preReceive.ts 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1361      +/-   ##
==========================================
- Coverage   81.35%   81.26%   -0.09%     
==========================================
  Files          65       65              
  Lines        4639     4644       +5     
  Branches      792      793       +1     
==========================================
  Hits         3774     3774              
- Misses        850      855       +5     
  Partials       15       15              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fabiovincenzi fabiovincenzi requested review from a team, jescalada and kriswest and removed request for kriswest January 28, 2026 09:17
@fabiovincenzi fabiovincenzi mentioned this pull request Jan 30, 2026
16 tasks
Copy link
Contributor

@jescalada jescalada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests look good!

Wondering if we could keep the MongoDB combinations in the CI and think about whether we need a Windows CI execution since Windows test support is more of a quality-of-life thing for Windows development...

Signed-off-by: Fabio Vincenzi <93596376+fabiovincenzi@users.noreply.github.com>
@fabiovincenzi
Copy link
Contributor Author

Thanks for the review @jescalada!
It should be ready for another look.😃

Copy link
Contributor

@jescalada jescalada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix failing tests on Windows

2 participants