Skip to content

fix: correct the API base url used to call cancel push in admin UI#1394

Merged
kriswest merged 3 commits intomainfrom
1384-fix-cancel-api-base
Feb 9, 2026
Merged

fix: correct the API base url used to call cancel push in admin UI#1394
kriswest merged 3 commits intomainfrom
1384-fix-cancel-api-base

Conversation

@kriswest
Copy link
Contributor

@kriswest kriswest commented Feb 9, 2026

resolves #1384

Fixes a regression in the admin UI relating to the cancel push button by correcting the API URL base used to call the cancel push in admin UI, which was broken during the TS refactor.

Additionally, ignores the .data, .remote and .tmp folders in the vite config as I noted that data writes into these folders was causing the vite to reload the admin unnecessarily.

@kriswest kriswest requested review from a team and jescalada February 9, 2026 10:03
@netlify
Copy link

netlify bot commented Feb 9, 2026

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit 22afab2
🔍 Latest deploy log https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/6989b0f96e66b60008bc7076

@github-actions github-actions bot added the fix label Feb 9, 2026
@github-actions
Copy link

github-actions bot commented Feb 9, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails
npm/diff 4.0.4 🟢 3.4
Details
CheckScoreReason
Dangerous-Workflow⚠️ -1no workflows found
Packaging⚠️ -1packaging workflow not detected
Maintained🟢 109 commit(s) and 12 issue activity found in the last 90 days -- score normalized to 10
Code-Review⚠️ 1Found 4/27 approved changesets -- score normalized to 1
Binary-Artifacts🟢 10no binaries found in the repo
Token-Permissions⚠️ -1No tokens found
Pinned-Dependencies⚠️ -1no dependencies found
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Security-Policy⚠️ 0security policy file not detected
Fuzzing⚠️ 0project is not fuzzed
License🟢 10license file detected
Signed-Releases⚠️ -1no releases found
Branch-Protection⚠️ 0branch protection not enabled on development/release branches
Vulnerabilities⚠️ 28 existing vulnerabilities detected
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0

Scanned Files

  • package-lock.json

@codecov
Copy link

codecov bot commented Feb 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.34%. Comparing base (2452f10) to head (22afab2).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1394   +/-   ##
=======================================
  Coverage   81.34%   81.34%           
=======================================
  Files          65       65           
  Lines        4648     4648           
  Branches      792      792           
=======================================
  Hits         3781     3781           
  Misses        852      852           
  Partials       15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@jescalada jescalada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just wondering if we ought to standardize these "Base URLs" a bit more since we have some places using getBaseUrl which is the same except that it doesn't include the API version...

@kriswest
Copy link
Contributor Author

kriswest commented Feb 9, 2026

LGTM! Just wondering if we ought to standardize these "Base URLs" a bit more since we have some places using getBaseUrl which is the same except that it doesn't include the API version...

Might be a docs issue? getBaseUrl is the server base (root URL), while apiV1Base is the API base under that...

@kriswest kriswest merged commit 784bfc4 into main Feb 9, 2026
25 checks passed
@jescalada
Copy link
Contributor

Just double-checked that one, and indeed the getApiV1BaseUrl function is building the URL from getBaseUrl 😃

It seems all calls to /api/auth endpoints are using getBaseUrl directly, and the others are using apiV1Base. I understand we're deliberately keeping the auth endpoints and the business logic endpoints separate - it's just not entirely obvious why we need different functions for each one.

@kriswest kriswest mentioned this pull request Feb 9, 2026
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cancelling pushes does not work in the admin UI (regression)

2 participants