fix: correct the API base url used to call cancel push in admin UI#1394
fix: correct the API base url used to call cancel push in admin UI#1394
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1394 +/- ##
=======================================
Coverage 81.34% 81.34%
=======================================
Files 65 65
Lines 4648 4648
Branches 792 792
=======================================
Hits 3781 3781
Misses 852 852
Partials 15 15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jescalada
left a comment
There was a problem hiding this comment.
LGTM! Just wondering if we ought to standardize these "Base URLs" a bit more since we have some places using getBaseUrl which is the same except that it doesn't include the API version...
Might be a docs issue? |
|
Just double-checked that one, and indeed the It seems all calls to |
resolves #1384
Fixes a regression in the admin UI relating to the cancel push button by correcting the API URL base used to call the cancel push in admin UI, which was broken during the TS refactor.
Additionally, ignores the .data, .remote and .tmp folders in the vite config as I noted that data writes into these folders was causing the vite to reload the admin unnecessarily.