fix: check for body type before parsePush execution#1511
Open
jescalada wants to merge 6 commits intofinos:mainfrom
Open
fix: check for body type before parsePush execution#1511jescalada wants to merge 6 commits intofinos:mainfrom
jescalada wants to merge 6 commits intofinos:mainfrom
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1511 +/- ##
==========================================
- Coverage 90.21% 90.18% -0.04%
==========================================
Files 69 69
Lines 5511 5514 +3
Branches 944 946 +2
==========================================
+ Hits 4972 4973 +1
- Misses 521 523 +2
Partials 18 18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jescalada
commented
Apr 23, 2026
| - name: Publish git-proxy-plugin-samples | ||
| working-directory: plugins/git-proxy-plugin-samples | ||
| run: | | ||
| npm install --include=peer |
Contributor
Author
There was a problem hiding this comment.
This bit had to be removed in order to fix the "unpinned dependency" alert https://github.com/finos/git-proxy/security/code-scanning/113. I think this shouldn't cause issues since the published package wouldn't include the peer dep (finos/git-proxy) - unless I'm missing something 🤔
Pinging @coopernetes just in case!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1509.