Skip to content

fix: check for body type before parsePush execution#1511

Open
jescalada wants to merge 6 commits intofinos:mainfrom
jescalada:code-scanning-fixes
Open

fix: check for body type before parsePush execution#1511
jescalada wants to merge 6 commits intofinos:mainfrom
jescalada:code-scanning-fixes

Conversation

@jescalada
Copy link
Copy Markdown
Contributor

Fixes #1509.

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 22, 2026

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit aa7c42c
🔍 Latest deploy log https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/69e97d10f4e5d10008363e5c

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.18%. Comparing base (6981427) to head (aa7c42c).

Files with missing lines Patch % Lines
src/proxy/processors/push-action/parsePush.ts 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1511      +/-   ##
==========================================
- Coverage   90.21%   90.18%   -0.04%     
==========================================
  Files          69       69              
  Lines        5511     5514       +3     
  Branches      944      946       +2     
==========================================
+ Hits         4972     4973       +1     
- Misses        521      523       +2     
  Partials       18       18              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jescalada jescalada marked this pull request as ready for review April 23, 2026 02:24
@jescalada jescalada requested a review from a team as a code owner April 23, 2026 02:24
- name: Publish git-proxy-plugin-samples
working-directory: plugins/git-proxy-plugin-samples
run: |
npm install --include=peer
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bit had to be removed in order to fix the "unpinned dependency" alert https://github.com/finos/git-proxy/security/code-scanning/113. I think this shouldn't cause issues since the published package wouldn't include the peer dep (finos/git-proxy) - unless I'm missing something 🤔

Pinging @coopernetes just in case!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix code scanning alerts

1 participant