feat: dependency-check-plugin-revision#1529
Open
RichardUri wants to merge 2 commits into
Open
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
kriswest
reviewed
May 11, 2026
Contributor
kriswest
left a comment
There was a problem hiding this comment.
It seems odd to have a plug-in to a complete extra clone of the repository and compute its own diff in order to run scanning tools on it, when when the built-in scanners already do both of these things... Can this not be written to use the data from the existing clone and diff operations?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Revises and addresses review feedback on #799, adding dependency vulnerability scanner plugin.
The plugin is intended to intercept pushes and scans changed dependency files against the OWASP Vuln database. If a vulnerability is found at or above a severity threshold, the push will be held for review.
Made changes according to reviewer comments on original PR.
General changes:
DEPENDENCY_VULN_THRESHOLDenvironment variable (default:HIGH) rather than a top-level config schema entrygit diffargument order (Previously showed removals instead of additions)git showusingHEADinstead of the pushed commit SHAsrc/lib/foo.json)deleteTempReponow deletes the entire.tempRepo/directory instead of only the current push's subdirectorydependency-checkto prevent silent false negatives on failurespawnSyncfor the clone operation with asyncspawnto avoid blockingthe Node.js event loop
pullRemoteprocessorexportsentry and README documentation for the new pluginRelated Issue
Revises #799
Checklist
General
Documentation
Configuration
config.schema.json) was modified:npm run generate-config-types)npm run gen-schema-doc)Tests
npm test)npm run lintandnpm run format:check)npm run check-types)