Conversation
- failing test: regressions.html -> Updates -> saving a computed expression column does not interrupt update rendering
- currently just the jest tests
- only "...computed expression column..." test is the regressions test still failing. This is due to the fact that the code in @finos/perspective-viewer master (what our test expects) is ahead of what's in the 0.4.8 release (what ends up in our bundle) - the styling still needs @finos/perspective-viewer as a runtime dependency included in the bundle, though technically we never import it anywhere in the html-grid source code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this gets pulled in I'll add a couple more commits fixing some build config and changing all refs
html-grid=>regular-table