Skip to content

Incrementally call styleHandlers, and remove intermediate <div>#104

Merged
texodus merged 3 commits intomasterfrom
remove-div-wrapper
Jan 13, 2021
Merged

Incrementally call styleHandlers, and remove intermediate <div>#104
texodus merged 3 commits intomasterfrom
remove-div-wrapper

Conversation

@texodus
Copy link
Copy Markdown
Member

@texodus texodus commented Jan 13, 2021

A few big-picture API cleanup changes in this PR, and a few bugs:

  • Refactors perspective.md model to separate dataListener() and formatStyleListener() into separate functions.
  • styleHandlers are now invoked incrementally when a column's widths are not known, with total width calculation being deferred until pagination. This clears up a whole category of resize bugs involving columns failing to render for just the first call to draw().
  • The default DOM structure has been simplified (due to browser bug fixes since publication) to remove an intermediate <div> layer.
<regular-table>
    <div>
        <table></table>
    </div>
</regular-table>

vs.

<regular-table>
    <table></table>
</regular-table>
  • Fixes overscroll behavior due to browser "bounce" on browser which bounce.
  • Fixes test instability via jest-puppeteer-docker for docker based image recreation.

@texodus texodus added the bug Concrete, reproducible bugs label Jan 13, 2021
@texodus texodus merged commit 844e486 into master Jan 13, 2021
@texodus texodus deleted the remove-div-wrapper branch January 13, 2021 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Concrete, reproducible bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant