Skip to content

Fixup jsdoc annotations, carry fixups over to typescript typings#111

Merged
texodus merged 2 commits intofinos:masterfrom
telamonian:jsdoc-typescript-fixup
Feb 5, 2021
Merged

Fixup jsdoc annotations, carry fixups over to typescript typings#111
texodus merged 2 commits intofinos:masterfrom
telamonian:jsdoc-typescript-fixup

Conversation

@telamonian
Copy link
Copy Markdown
Contributor

Fixes #110

This PR fixes the typos and other minor issues in the jsdocs mentioned in #110, carries those fixes over to the typescript typings in index.d.ts, and makes a couple of other minor by-hand fixes to index.d.ts, such as including the .draw method in the RegularTableElement typing

@texodus
Copy link
Copy Markdown
Member

texodus commented Feb 5, 2021

Thanks for the PR! Looks good!

@texodus texodus merged commit a9b4679 into finos:master Feb 5, 2021
@texodus texodus added the internal Internal refactoring and code quality improvement label Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Internal refactoring and code quality improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

There are some minor typos in the jsdoc annotations

2 participants