wrap any plain text column headers in a <span>#117
Conversation
|
This PR also fixes an API consistency issue w.r.t. what is a valid value for a column_header entry. Previously, you could pass an html string such as On the other hand, row_header values have the exact opposite handling ( All of which is to say that we should probably consider doing a |
|
All of the unittests now pass locally. A bunch of tests needed fixes w.r.t. the fact that column-headers are now rendered slightly differently. Most fixes were trivial, except for the sort-handling in the perspective example. The previous @texodus Can you please review? |
|
Thanks for the PR! Looks good! |
As discussed with @texodus, this PR changes the creation of column header nodes such that any text is wrapped up in a
<span>element before getting added. As opposed to now, where any text is just included as a raw text node.