Return an unsubscribe function from addStyleListener#121
Merged
texodus merged 1 commit intofinos:masterfrom Mar 26, 2021
NMinhNguyen:remove-style-listener
Merged
Return an unsubscribe function from addStyleListener#121texodus merged 1 commit intofinos:masterfrom NMinhNguyen:remove-style-listener
addStyleListener#121texodus merged 1 commit intofinos:masterfrom
NMinhNguyen:remove-style-listener
Conversation
Member
|
Looks good! Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a breaking change because it changes the return value of
addStyleListener. That being said, the return value wasn't particularly useful because there was no public API to remove subscribed listeners.