Skip to content

Update to License, Notice and Readme files#175

Merged
texodus merged 3 commits intofinos:masterfrom
TheJuanAndOnly99:master
Feb 15, 2023
Merged

Update to License, Notice and Readme files#175
texodus merged 3 commits intofinos:masterfrom
TheJuanAndOnly99:master

Conversation

@TheJuanAndOnly99
Copy link
Copy Markdown
Member

@TheJuanAndOnly99 TheJuanAndOnly99 commented Dec 20, 2022

- JP Morgan Chase should be on the LICENSE and NOTICE files

  • FINOS "active" and OpenSSF "passing" badges
  • Contributing + License sections added to readme

texodus

This comment was marked as outdated.

Comment thread README.md
Comment thread README.md
@timkpaine

This comment was marked as outdated.

@finos finos deleted a comment from timkpaine Jan 1, 2023
@TheJuanAndOnly99
Copy link
Copy Markdown
Member Author

Hi @timkpaine @texodus ! Thanks for your feedback I think you raise great points. I have:

  • Updated the PR to revert the copyright to how it was.
  • Removed the contributing section from the readme and updated the license section (What do you think of having an AUTHORS file like in jupyter_templates?)
  • Removed the OpenSSF badge. Though we would like it to be mentioned somewhere in the readme that this project achieves the OpenSFF passing badge with a link to the project page on the openSFF best practices website https://bestpractices.coreinfrastructure.org/en/projects/6771 (I'll leave it up to you on where we can put this).

Thank you and please let me know what you think!

@timkpaine
Copy link
Copy Markdown
Member

  • Removed the contributing section from the readme and updated the license section (What do you think of having an AUTHORS file like in jupyter_templates?)

@maoo and i like the AUTHORS file approach, im sure @texodus won't mind.

Removed the OpenSSF badge. Though we would like it to be mentioned somewhere in the readme that this project achieves the OpenSFF passing badge with a link to the project page on the openSFF best practices website https://bestpractices.coreinfrastructure.org/en/projects/6771 (I'll leave it up to you on where we can put this).

maybe in the development block is ok

@TheJuanAndOnly99
Copy link
Copy Markdown
Member Author

@maoo and i like the AUTHORS file approach, im sure @texodus won't mind.

I've added a AUTHORS file. Feel free to send me list of authors or modify as needed.

maybe in the development block is ok

Added a small section in the development block

fix link

revert copyright, remove contributing, change license in readme, remove openssf badge

add AUTHORS file plus mention OpenSSF

Update README.md

update Authors for other info
@TheJuanAndOnly99
Copy link
Copy Markdown
Member Author

Hi @texodus @timkpaine thank you for your collaboration. This is good to go on our end, feel free to merge when ready.

Comment thread README.md Outdated
@timkpaine timkpaine dismissed stale reviews from texodus and themself February 9, 2023 20:10

stale

@texodus texodus merged commit d36d154 into finos:master Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants