Adds file_browser.html example (update for row_headers feature)#25
Adds file_browser.html example (update for row_headers feature)#25
row_headers feature)#25Conversation
row_headers feature)row_headers feature)
telamonian
left a comment
There was a problem hiding this comment.
LGTM!
The only other thing I'd like to get in as part of this PR is a way to set a text title on the names column (ie the row_headers column). You can sort of do it via row_pivots, but a) that's obviously not what it's for and b) in that case the column name still isn't visible. It's not a blocker, though
|
|
||
| td th span.pd-group-leaf, th span.pd-group-leaf { | ||
| margin-left: 12px; | ||
| margin-left: 16px; |
There was a problem hiding this comment.
This is a fix for the issue where the <span class="pd-row-header-icon"> elements were throwing off the alignment of the dir/file names, right? Nice work
There was a problem hiding this comment.
Yes - Perspective has no way to generate datasets with "folders" at the same level as "leaves", so this number was off a few pixels.
|
Thanks for the review! I will think about concise ways to name the "corner" as well, PRs welcome. |
Updates #19 from @telamonian to rely on the new
row_headersfeature introduced in #24 . Theadd-filebrowser-examplebranch was first rebased:tree_row_header.jsand 'events.js` were removed.perspective.htmlwere removed (which relied on the above).Next, the example was refactored. Unfortunately some of my comments from the original PR were quickly outdated by rapid progress on this API.
__config,__collapseand__expandpass-through.row_headersinstead ofrow_indices, et al columns.perspective.html, modified to handle the lack of an empty 'root' node.collapseandexpand()