Add x1, y1 to getMeta()#55
Merged
texodus merged 1 commit intofinos:masterfrom Jun 17, 2020
Merged
Conversation
Closed
texodus
approved these changes
Jun 17, 2020
Member
texodus
left a comment
texodus
left a comment
There was a problem hiding this comment.
Looks good!
There is one stipulation, that x1 may be slightly inaccurate, since it does not take into account extensions performed when the initial data window requested doesn't fill up the viewport width. I think given the nature of what this is used for, that this probably only merits documentation mention for now.
Member
|
Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR exposes the
x1andy1passed to theDataListenerwhen invoked viaMetaData.