Adds manually written index.d.ts typescript type declaration#65
Merged
texodus merged 3 commits intofinos:masterfrom Jun 20, 2020
Merged
Adds manually written index.d.ts typescript type declaration#65texodus merged 3 commits intofinos:masterfrom
texodus merged 3 commits intofinos:masterfrom
Conversation
3 tasks
Member
|
Thanks for the PR! Looks good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've tested this PR out by
yarn linking-ing it into an external typescript project. The typings seems to work well.index.d.tsRegularTableElement.scrollToshadows baseHTMLElement.scrollTomethod #54: renamedscrollTo->scrollToCell, so that the method can be included inindex.d.tswithout the typescript compiler complaining about shadowing of the base class method@texodus 9bd534d added docstrings for the
RegularTableElementprivate methods:@internal @privatetags to the private docstrings. In theory, that means these private docstrings will get ignored both by jsdoc and at least one declaration generator that we can experiment with later