Add keyboard nav#70
Merged
texodus merged 5 commits intofinos:masterfrom Jun 25, 2020
Merged
Conversation
Scroll ahead by a few columns in all directions Begin porting to spreadsheet.md Add update to virtual index on click
texodus
approved these changes
Jun 25, 2020
| with the `x` and `y` coordinates currently focused so that we can scroll | ||
| to another distant part of the table and back with our selection preserved. | ||
| We can default it to the origin. | ||
|
|
Member
There was a problem hiding this comment.
Please leave out as much leading/trailing white-space as you can in the future for code segments - this is stripped via processing script for bl.ocks but it is still a bit cumbersome to read.
| } | ||
| break; | ||
| // left arrow | ||
| case 37: |
Member
There was a problem hiding this comment.
Seems like making these enums/const would make this code self-documenting
| } | ||
| } | ||
|
|
||
| if (dy !== 0) { |
Member
There was a problem hiding this comment.
These two conditional blocks look like they could be simplified/merged ..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.