Skip to content

Refactor Area Mouse Selection, update area clipboard and test suite#79

Merged
texodus merged 9 commits intofinos:masterfrom
JHawk:update-clipboard-example
Aug 28, 2020
Merged

Refactor Area Mouse Selection, update area clipboard and test suite#79
texodus merged 9 commits intofinos:masterfrom
JHawk:update-clipboard-example

Conversation

@JHawk
Copy link
Copy Markdown
Contributor

@JHawk JHawk commented Aug 5, 2020

  • Cleaning up the Area Mouse Selection example to use selection objects more consistent with other examples and the DataModel to represent a selection.
  • Broke up test files for clarity and speed of execution - removed some redundancy.
  • Rewrote the Area Clipboard example to literally style

@JHawk JHawk changed the title Update mouse area selections to object x0, x1, y0, y1 format Refactor Area Mouse Selection and test suite Aug 7, 2020
@JHawk JHawk changed the title Refactor Area Mouse Selection and test suite Refactor Area Mouse Selection, update area clipboard and test suite Aug 18, 2020
@JHawk JHawk force-pushed the update-clipboard-example branch from 75f275b to e663b96 Compare August 18, 2020 19:44
Copy link
Copy Markdown
Member

@texodus texodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! This is a significant improvement.

@texodus texodus merged commit 210d046 into finos:master Aug 28, 2020
@texodus
Copy link
Copy Markdown
Member

texodus commented Aug 28, 2020

Thanks for the PR!

@texodus texodus added the bug Concrete, reproducible bugs label Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Concrete, reproducible bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants