Conversation
texodus
force-pushed
the
staging-light-dom
branch
from
6a16c9c to
346f523
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
swapoption for thedraw()method, which replaces the existing constant value. With this change,<table>swapping will only occur when this flag is set.In addition, the container element used for 'staging" changes during a swap has been moved to the light DOM, as a child of
<regular-table>, sibling to the visible<table>container element. This allows CSS style which may impact layout, such as font size and cell dimensions, to be calculated correctly in swapped mode; as a side effect however, naive of async calls toquerySelector()may resolve both hidden and cloned visible table elements.