Skip to content

Don't preventDefault() scroll when the table is at scroll min or max #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
texodus merged 1 commit into from
Sep 14, 2020
Merged

Don't preventDefault() scroll when the table is at scroll min or max #90

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions src/js/events.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,14 +70,16 @@ export class RegularViewEventModel extends RegularVirtualTableViewModel {
if (this._virtual_scrolling_disabled) {
return;
}
event.preventDefault();
event.returnValue = false;
const {clientWidth, clientHeight, scrollTop, scrollLeft} = this;
const total_scroll_height = Math.max(1, this._virtual_panel.offsetHeight - clientHeight);
const total_scroll_width = Math.max(1, this._virtual_panel.offsetWidth - clientWidth);
this.scrollTop = Math.min(total_scroll_height, scrollTop + event.deltaY);
this.scrollLeft = Math.min(total_scroll_width, scrollLeft + event.deltaX);
this._on_scroll(event);
const {clientWidth, clientHeight, scrollTop, scrollLeft, scrollHeight} = this;
if ((event.deltaY > 0 && scrollTop + clientHeight < scrollHeight) || (event.deltaY < 0 && scrollTop > 0) || event.deltaY === 0) {
event.preventDefault();
event.returnValue = false;
const total_scroll_height = Math.max(1, this._virtual_panel.offsetHeight - clientHeight);
const total_scroll_width = Math.max(1, this._virtual_panel.offsetWidth - clientWidth);
this.scrollTop = Math.min(total_scroll_height, scrollTop + event.deltaY);
this.scrollLeft = Math.min(total_scroll_width, scrollLeft + event.deltaX);
this._on_scroll(event);
}
}

/**
Expand Down